Skip to content

DATAJDBC-267 - Fix Jdbc configuration to support multiple stores #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

DATAJDBC-267 - Fix Jdbc configuration to support multiple stores #89

wants to merge 2 commits into from

Conversation

michael-simons
Copy link
Contributor

I spoke briefly with @schauder about that change to fix DATAJDBC-267 while he is on the plane. Would you mind having a look @mp911de ? This is pretty much the same behavior data-mongo has, but I couldn't find a test for the specific JdbcConfiguration class. AFAIK it is never actually invoked during the current JDBC tests.

@mp911de mp911de changed the title Fix Jdbc configuration to support multiple stores DATAJDBC-267 - Fix Jdbc configuration to support multiple stores Sep 21, 2018
@wilkinsona
Copy link
Member

Thank you, @michael-simons. FWIW, I think it would be worth changing this line so that the @Bean method's signature indicates that it returns JdbcCustomConversions rather than just CustomConversions. That extra type information is useful during dependency resolution.

@mp911de If a snapshot of these changes could be made available, I'm more than happy to test them in Boot's build (which does have test coverage for JdbcConfiguration).

@christophstrobl
Copy link
Member

@wilkinsona I'll set up the accoding issue branch and pull in the changes from @michael-simons. Will also apply the suggested change. @mp911de is already in another time zone

@christophstrobl
Copy link
Member

christophstrobl commented Sep 21, 2018 •
edited
Loading

@wilkinsona 1.0.0.DATAJDBC-267-SNAPSHOT should now be available - If you can confirm it works @mp911de will merge the changes to master later today.

@wilkinsona
Copy link
Member

Looks good to me. Thanks for the fix.

mp911de pushed a commit that referenced this pull request Sep 21, 2018
@michael-simons @mp911de
DATAJDBC-267 - Explicitly use the own custom conversions bean.
be7c04c 
Original pull request: #89.
mp911de pushed a commit that referenced this pull request Sep 21, 2018
@christophstrobl @mp911de
DATAJDBC-267 - Favor JdbcCustomConversions over CustomConversions in …
234a17d 
…return type.

Original pull request: #89.
mp911de added a commit that referenced this pull request Sep 21, 2018
@mp911de
DATAJDBC-267 - Polishing.
bf81c72 
Add author tags. Extend Javadoc.

Original pull request: #89.
@mp911de
Copy link
Member

mp911de commented Sep 21, 2018

That's merged and polished now.

@mp911de mp911de closed this Sep 21, 2018
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
mp911de added a commit that referenced this pull request Feb 21, 2022
@mp911de
#89 - Accept SQL directly in DatabaseClient.execute(…) stage.
8b77aa9 
We compressed client.execute().sql(…) to client.execute(…) to not require the intermediate execute() step but rather accept the SQL to execute directly.

Original pull request: #112.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-simons @wilkinsona @christophstrobl @mp911de